i just want to check it why its not working can you try it because in my friend laptop it was working pls help

fid = fopen('MATLAB.txt', 'r');%Read the file 
n = 0;
while ~feof(fid)   
    line1 = fgetl(fid);
    line = string(line1);%Read line of text
    s = split(line);
    n = n + length(s);%Define length of words
end
fclose(fid);
%Calculate words
fprintf('Number of words: %d\n', n);
%==================================
n1=0;
for i=1:length(s)
    %Conver string to characters
    character=convertStringsToChars(s(i));
    %Read each charcater length
    if(length(character)==3)
        n1=n1+1;
    else
        n1=0;
    end
end
%Define letters
fprintf('Number of words contain only three letters: %d\n', n1);

%=========================================================
n1=0;
for i=1:length(s)
    character=convertStringsToChars(s(i));
    %%Check charcatwr consiste if letter A
    if(character(1)=='A')
        n1=n1+1;
    else
        n1=0;
    end
end
fprintf('Number of words Starts with A letters: %d\n', n1);
%=================================================================
k1=0;
for i=1:length(s)
    character=convertStringsToChars(s(i));
    n1=0;
    n2=0;
    for k=1:length(character)
        if(character(k)=='A')
            n1=n1+1;
            %%Read chaaracter E
        elseif(character(k)=='E')
            n2=n2+1;
        else
            k2=0;
        end
    end
    if(n2==0 || n1==0)
        k1=0;
    else
        k1=k1+1;
    end
    
end
fprintf('Number of words contain A and E letters: %d\n', k1+1);

%%=================================================================
Cc = double(line1(:));
B = double(['A':'Z' 'a':'z']);      % Create Bin Ranges
Hcts2 = histc(Cc,B);
CB = char(B); 
for k1 = 1:4                        % Output Table
    idxrng = (1:13)+13*(k1-1);
    fprintf(1,['\n\t' repmat(' —%c— ', 1, 13) '\n'], CB(idxrng))
    fprintf(1,['\n\t' repmat('%3d  ', 1, 13) '\n\n'], Hcts2(idxrng))
end

[John D'Errico]

There can be virtually infinitely many reasons why it does not run for you. But we cannot possibly help you. Do you not have a function that is called? Perhaps you have a too old MATLAB release. Perhaps you just don't have the.txt file it calls. Perhaps you have some corrupted files on your computer. Do you just not know how to use a script file? I could go on forever. And of course, we cannot even test that code.

So learn to use the debugger. If there is a problem running the code, then learn to read the error mesage that MATLAB returns. If that fails, then learn that if you want help, then you need to actually show the error message that is generated, the COMPLETE error message, thus EVERYTHING in red.

If you have a problem, the best way to fix it is to learn to use the tools you are using. If you need help, then make it possible to get help. You have not done either of those things.

[Saleh]

Index exceeds the number of array elements. Index must not exceed 0.

Error in File (line 36)

if(character(1)=='A')

this is the error, thanks for your comment you told me to write by my own last time and still i have error which we done the same in our friend laptop. thanks

[Saleh]

please help me please

[Image Analyst]

@Saleh we're waiting for you to attach 'MATLAB.txt' and explain in a LOT more detail what "not working" means to you. I'm not doing anything until then.

[Rik]

Have a read here and here. It will greatly improve your chances of getting an answer. If you have trouble with Matlab basics you may consider doing the Onramp tutorial (which is provided for free by Mathworks).

[Jan]

The file import is strange: You count the words in the lines, but store the words of the last line only. Does the input file contain 1 line only? Then the loop is nonsense. Use fileread() instead.

In the 2nd section you convert the strings to CHARs only to count their characters? Why not using strlength()? A loop is not required also. But if you use a loop, resetting the counter to 0, when a word has not 3 characters, is very strange.

The 3rd section can be solved in 1 line using the command startsWith.

The 4th section looks very strange. Again 1 line would be enough using contains, but your loop resets the counters to 0 inside again. This is not the way counting works. And you do you output k1+1?

You did not mention, what is "not working". It is easier to fix a problem than to guess, what the problem is.

[Saleh]

you are master jon you cannot compare your knowledge by my knowldge thanks alot for helping but if you make it simple also i will be happy and gland thanks for your comments MASTERS.

[Image Analyst]

Yeah ok but did you see my and @Rik's comments? Are we done here, or are you going to attach your .txt file?

[Saleh]

jan* glad*

sorry for mistakes

[Saleh]

Coding, sometimes called computer programming, is how we communicate with computers. Code tells a computer what actions to take, and writing code is like creating a set of instructions. By learning to write code, you can tell computers what to do or how to behave in a much faster way. You can use this skill to make websites and apps, process data, and do lots of other cool things. We all have hopes, dreams, and plans for the future. Whether you’re looking for a new opportunity, want to optimize your current job, or are simply searching for a new hobby, coding can help you get closer to your goals. And remember, anyone can learn how to code!

this paraghragh up is my MATLAB.txt

[Saleh]

i already sure the contant in the file it starts from coding until to code !

if matlab don't accept this sign (!) i will remove it no problem

Answer 1

[Jan]

s = fileread('MATLAB.txt');
words = strsplit(s);

Do you see it? The code can be simplified massively.

n1=0;  % Just a hint: why a "1" in n1? The simpler, the better. Use "n".
for i = 1:length(s)
    % Convert string to characters % Avoid indirections. Use strlength()
    % instead.
    
    % character=convertStringsToChars(s(i));
    % Simpler: c = char/s(i));
    
    % Read each charcater length
    if strlength(c)==3)
        n1=n1+1;
    % No! else
    % No!    n1=0;  % Do not reset n1 inside the loop
    end
end

Much cleaner without a loop:

% Number of words with 3 characters:
n = nnz(strlength(words) == 3);

Use startsWith() and contains() for the other parts.

It is hard to guess if the histogram part meets the requirements, because you did not post, what is asked for. So if you still have problems, explain them.

[Saleh]

i can use this in all sections jan ? or what sorry i confused i want help really to make it simple mice looks like disaster

[Saleh]

im new in this please don't take it personaly

[Saleh]

%jan still i have error

n=0;
for i=1:length(s)
    
    character=char(s(i)) %Conver string to characters
    if strlength(character)==3) %Read each charcater length
        n=n+1;
        
    end
end

%this what u told me to do but still

% This is the error ( the error in the code you told me to adjust ))

File: File.m Line: 26 Column: 31

Invalid expression. When calling a function or indexing a variable, use parentheses. Otherwise, check for mismatched delimiters.

[Walter Roberson]

if strlength(character)==3 %Read each charcater length

[Dongyue]

for the script below

if strlength(character)==3)

a right parenthese need to be removed. This line should be:

if strlength(character)==3

[Jan]

@Saleh: As I have suggested already, replace this loop by this line:

n = nnz(strlength(s) == 3);  % Your "s" is called "words" in my suggestion

Use the same pattern to find words starting with the character "A":

n = nnz(startsWith(s, "A"));

and

n = nnz(contains(s, ["A", "E"]));
% maybe: contains(s, ["a", "e"], 'IgnoreCase', true);

As mentioned before: Without a description of the purpose and without copy of the error message, I cannot suggest a modification of the histogram section.

One of your problems was a not matching parenthesis. As long as you are not able to fix such trivial typos by your own, I do not see a chance, that you can solve the coming homework questions in the future.

Answer 2

[Walter Roberson]

feof() only predicts end-of-file in some circumstances. You need to test ischar() of the results of fgetl()

while ~feof(fid)   
    line1 = fgetl(fid);
    line = string(line1);%Read line of text
    s = split(line);
    n = n + length(s);%Define length of words
end

s is only going to hold the result for the last fgetl()

[Jan]

@Walter Roberson: The example file posted by the OP seems to contain 1 line only: At least when I copy&paste the text, it does not contain line breaks. Therefore this code works magically.

[Saleh]

walter and jan sorry but see my code i know you can make it all simple ;')

fid = fopen('MATLAB.txt', 'r');%Read the file 
n = 0;
while ~feof(fid)   
    line1 = fgetl(fid);
    line = string(line1);%Read line of text
    s = split(line);
    n = n + length(s);%Define length of words
end
fclose(fid);
%Calculate words
fprintf('Number of words: %d\n', n);
%==================================
n1=0;
for i=1:length(s)
    %Conver string to characters
    character=convertStringsToChars(s(i));
    %Read each charcater length
    if(length(character)==3)
        n1=n1+1;
    else
        n1=0;
    end
end
%Define letters
fprintf('Number of words contain only three letters: %d\n', n1);
%=========================================================
n1=0;
for i=1:length(s)
    character=convertStringsToChars(s(i));
    %%Check charcatwr consiste if letter A
    if(character(1)=='A')
        n1=n1+1;
    else
        n1=0;
    end
end
fprintf('Number of words Starts with A letters: %d\n', n1);
%=================================================================
k1=0;
for i=1:length(s)
    character=convertStringsToChars(s(i));
    n1=0;
    n2=0;
    for k=1:length(character)
        if(character(k)=='A')
            n1=n1+1;
            %%Read chaaracter E
        elseif(character(k)=='E')
            n2=n2+1;
        else
            k2=0;
        end
    end
    if(n2==0 || n1==0)
        k1=0;
    else
        k1=k1+1;
    end
    
end
fprintf('Number of words contain A and E letters: %d\n', k1+1);
%%=================================================================
Cc = double(line1(:));
B = double(['A':'Z' 'a':'z']);      % Create Bin Ranges
Hcts2 = histc(Cc,B);
CB = char(B); 
for k1 = 1:4                        % Output Table
    idxrng = (1:13)+13*(k1-1);
    fprintf(1,['\n\t' repmat(' —%c— ', 1, 13) '\n'], CB(idxrng))
    fprintf(1,['\n\t' repmat('%3d  ', 1, 13) '\n\n'], Hcts2(idxrng))
end

[Jan]

@Saleh: I've posted a massive simplification already and have mentioned the required commands before. Now you have selected Walter's answer as a solution, and post your original code ignoring all given hints. You do not even take the time to format your code properly.

Obviously it is time for me to leave this thread, because my attempts to help do not help.

[Saleh]

pro iwas searching for you also i search for this is the answer for your smpilification but i didn't find + i already take time on my code also i use your code im still having error i don't no why and sorry for that

[Saleh]

please help me i getting only errors i will make for you also the answer because u r helping me but really in that simplification what u send it''s not there

[Saleh]

hhhhhhhhhhhhhhhhhhhhhheeeeeeeeeeeeeeeeeeeeeeeeeelllllllllllllllllllllllllllllllpppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppppp me in all codes not only one code يارب صبرك

[Jan]

@Saleh: Stop this. Do not bump your question by posting comments, which do not contain additional information. This wastes the time of the readers and in consequence your time.