Preallocating a Matrix(For loop, Vectorization)?

12 visualizzazioni (ultimi 30 giorni)
I hear that preallocating a matrix before the for loop is efficeint , but why do i get the error " The value assigend to the variable might be unused", when used before vectorization ? Example code
%% Vectorization method
Y4=repmat(A,N,1);
Y4 = cell2mat(arrayfun(@(i) A^i, (1:N)', 'Uni', false)
%% Normal Multiplication method
Y5=repmat(A,N,1);
for i=1:N
Y5((i-1)*Dim+1:i*Dim,:)=A^i;
%disp i
end
  1 Commento
Stephen23
Stephen23 il 9 Mag 2019
Y4 = repmat(A,N,1); % This is NOT preallocation!
Y4 = ....
You are simply replacing one array with another array, which has nothing to do with preallocation. Preallocation requires specifying an entire array in memory before accessing parts of it using indexing (note that you are not using indexing into Y4).

Accedi per commentare.

Risposta accettata

James Tursa
James Tursa il 9 Mag 2019
Modificato: James Tursa il 9 Mag 2019
In these lines:
Y4=repmat(A,N,1);
Y4 = cell2mat(arrayfun(@(i) A^i, (1:N)', 'Uni', false)
The first line assigns something to Y4. The second line wipes out what you just assigned to Y4 in the first line and replaces it with something else from the second line. In other words, the first line is useless and the value assigned to Y4 in the first line is unused.
  3 Commenti
Stephen23
Stephen23 il 9 Mag 2019
Modificato: Stephen23 il 9 Mag 2019
",could i make that 2line of code more efficeint?"
Not really: both cell2mat and arrayfun are relatively slow. The fastest solution is likely by using an expilcit loop with a preallocated output array.
ManvsMachine
ManvsMachine il 9 Mag 2019
got it,appreciate that.thanks

Accedi per commentare.

Più risposte (0)

Community Treasure Hunt

Find the treasures in MATLAB Central and discover how the community can help you!

Start Hunting!

Translated by